fix(apps.create): clone via HTTPS+bot-PAT; activate bot users on creation
Coolify was failing all Gitea clones with "Permission denied (publickey)"
because the helper container's SSH hits git.vibnai.com:22 (Ubuntu host
sshd, which doesn't know Gitea keys), while Gitea's builtin SSH is on
host port 22222 (not publicly reachable).
Rather than fight the SSH topology, switch every Vibn-provisioned app
to clone over HTTPS with the workspace bot's PAT embedded in the URL.
The PAT is already stored encrypted per workspace and scoped to that
org, so this gives equivalent isolation with zero SSH dependency.
Changes:
- lib/naming.ts: add giteaHttpsUrl() + redactGiteaHttpsUrl(); mark
giteaSshUrl() as deprecated-for-deploys with a comment.
- lib/coolify.ts: extend CreatePublicAppOpts with install/build/start
commands, base_directory, dockerfile_location, docker_compose_location,
manual_webhook_secret_gitea so it's at parity with the SSH variant.
- app/api/mcp/route.ts:
- apps.create now uses createPublicApp(giteaHttpsUrl(...)) and pulls
the bot PAT via getWorkspaceBotCredentials(). No more private-
deploy-key path for new apps.
- apps.update adds git_commit_sha + docker_compose_location to the
whitelist.
- New apps.rewire_git tool: re-points an app's git_repository at the
canonical HTTPS+PAT URL. Unblocks older apps stuck on SSH URLs
and provides a path for PAT rotation without rebuilding the app.
- lib/gitea.ts: createUser() now issues an immediate PATCH to set
active: true. Gitea's admin-create endpoint creates users as inactive
by default, and inactive users fail permission checks even though
they're org members. GiteaUser gains optional `active` field.
- scripts/activate-workspace-bots.ts: idempotent backfill that flips
active=true for any existing workspace bot that was created before
this fix. Safe to re-run.
- AI_CAPABILITIES.md: document apps.rewire_git; clarify apps.create
uses HTTPS+PAT (no SSH).
Already unblocked in prod for the mark workspace:
- vibn-bot-mark activated.
- twenty-crm's git_repository PATCHed to HTTPS+PAT form; git clone
now succeeds (remaining unrelated error: docker-compose file path).
Made-with: Cursor
This commit is contained in:
@@ -402,7 +402,7 @@ export async function createPrivateDeployKeyApp(
|
||||
|
||||
export interface CreatePublicAppOpts {
|
||||
projectUuid: string;
|
||||
gitRepository: string; // https URL
|
||||
gitRepository: string; // https URL (can embed basic-auth creds for private repos)
|
||||
gitBranch?: string;
|
||||
portsExposes: string;
|
||||
serverUuid?: string;
|
||||
@@ -415,6 +415,13 @@ export interface CreatePublicAppOpts {
|
||||
isAutoDeployEnabled?: boolean;
|
||||
isForceHttpsEnabled?: boolean;
|
||||
instantDeploy?: boolean;
|
||||
installCommand?: string;
|
||||
buildCommand?: string;
|
||||
startCommand?: string;
|
||||
baseDirectory?: string;
|
||||
dockerfileLocation?: string;
|
||||
dockerComposeLocation?: string;
|
||||
manualWebhookSecretGitea?: string;
|
||||
}
|
||||
|
||||
export async function createPublicApp(opts: CreatePublicAppOpts): Promise<{ uuid: string }> {
|
||||
@@ -433,6 +440,13 @@ export async function createPublicApp(opts: CreatePublicAppOpts): Promise<{ uuid
|
||||
is_auto_deploy_enabled: opts.isAutoDeployEnabled ?? true,
|
||||
is_force_https_enabled: opts.isForceHttpsEnabled ?? true,
|
||||
instant_deploy: opts.instantDeploy ?? true,
|
||||
install_command: opts.installCommand,
|
||||
build_command: opts.buildCommand,
|
||||
start_command: opts.startCommand,
|
||||
base_directory: opts.baseDirectory,
|
||||
dockerfile_location: opts.dockerfileLocation,
|
||||
docker_compose_location: opts.dockerComposeLocation,
|
||||
manual_webhook_secret_gitea: opts.manualWebhookSecretGitea,
|
||||
});
|
||||
return coolifyFetch('/applications/public', {
|
||||
method: 'POST',
|
||||
|
||||
23
lib/gitea.ts
23
lib/gitea.ts
@@ -155,6 +155,7 @@ export interface GiteaUser {
|
||||
login: string;
|
||||
full_name?: string;
|
||||
email?: string;
|
||||
active?: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -168,7 +169,7 @@ export async function createUser(opts: {
|
||||
password: string;
|
||||
fullName?: string;
|
||||
}): Promise<GiteaUser> {
|
||||
return giteaFetch(`/admin/users`, {
|
||||
const created = await giteaFetch(`/admin/users`, {
|
||||
method: 'POST',
|
||||
body: JSON.stringify({
|
||||
username: opts.username,
|
||||
@@ -180,6 +181,26 @@ export async function createUser(opts: {
|
||||
source_id: 0,
|
||||
}),
|
||||
});
|
||||
|
||||
// Gitea's admin-create endpoint returns users with `active=false` by
|
||||
// default (a quirk of the admin API — UI-created users skip email
|
||||
// verification but API-created ones don't). Inactive users fail
|
||||
// permission checks and cannot clone private repos, so we flip the
|
||||
// flag immediately via a PATCH. Idempotent: a second call is a noop.
|
||||
try {
|
||||
await giteaFetch(`/admin/users/${opts.username}`, {
|
||||
method: 'PATCH',
|
||||
body: JSON.stringify({
|
||||
source_id: 0,
|
||||
login_name: opts.username,
|
||||
active: true,
|
||||
}),
|
||||
});
|
||||
(created as GiteaUser).active = true;
|
||||
} catch (err) {
|
||||
console.warn('[gitea] failed to activate bot user', opts.username, err);
|
||||
}
|
||||
return created;
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -60,10 +60,49 @@ export function isDomainUnderWorkspace(fqdn: string, workspaceSlug: string): boo
|
||||
|
||||
/**
|
||||
* Build a Gitea SSH clone URL for a repo in a workspace's org.
|
||||
* Matches what Coolify's `private-deploy-key` flow expects.
|
||||
*
|
||||
* NOTE: As of 2026-04 this is deprecated for Coolify-driven deploys on
|
||||
* vibnai.com — Gitea's builtin SSH is bound to host port 22222 which is
|
||||
* not publicly reachable, and the default port 22 hits Ubuntu's host
|
||||
* sshd which doesn't know about Gitea keys. Use {@link giteaHttpsUrl}
|
||||
* instead and embed the workspace bot's PAT. Kept for read-only places
|
||||
* (e.g. UI display) that want the canonical "clone with SSH" form.
|
||||
*/
|
||||
export function giteaSshUrl(org: string, repo: string, giteaHost = 'git.vibnai.com'): string {
|
||||
return `git@${giteaHost}:${org}/${repo}.git`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Build a Gitea HTTPS clone URL with basic-auth credentials embedded.
|
||||
*
|
||||
* https://{username}:{token}@{host}/{org}/{repo}.git
|
||||
*
|
||||
* This is what we pass to Coolify's `git_repository` field for every
|
||||
* Vibn-provisioned app. Works regardless of SSH topology and scopes
|
||||
* access to whatever the bot user can see. The token is usually the
|
||||
* per-workspace Gitea bot PAT.
|
||||
*
|
||||
* We URL-encode the username and token so PATs with special chars
|
||||
* (`:`, `/`, `@`, `#`, `?`, etc.) don't break URL parsing.
|
||||
*/
|
||||
export function giteaHttpsUrl(
|
||||
org: string,
|
||||
repo: string,
|
||||
username: string,
|
||||
token: string,
|
||||
giteaHost = 'git.vibnai.com'
|
||||
): string {
|
||||
const u = encodeURIComponent(username);
|
||||
const t = encodeURIComponent(token);
|
||||
return `https://${u}:${t}@${giteaHost}/${org}/${repo}.git`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Redact the credentials from a Gitea HTTPS URL for safe logging /
|
||||
* display. Leaves the repo path intact. No-op for non-HTTPS URLs.
|
||||
*/
|
||||
export function redactGiteaHttpsUrl(url: string): string {
|
||||
return url.replace(/^(https?:\/\/)[^@]+@/, '$1***:***@');
|
||||
}
|
||||
|
||||
export { VIBN_BASE_DOMAIN };
|
||||
|
||||
Reference in New Issue
Block a user